Fix calling pathBasename twice during loadOrderSort #11115
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a medium sized app on Windows, these are some times from sorting files in 3 architectures during full rebuilds:
Before: 153ms, 140, 358, 391, 219, 177
After removing duplicate
files.pathBasename
: 84ms, 58, 73, 49, 114, 88In the future, an additional optimization we could consider is using
path.posix.basename
instead offiles.pathBasename
.files.pathBasename
converts paths to the os style path, then uses thebasename
function for the os. This conversion is probably unnecessary since all paths should be in posix format and are relative.With posix basename: 57ms, 38, 25, 30, 40, 70, 43