Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Apollo skeleton #11119

Merged
merged 6 commits into from
Aug 10, 2020
Merged

Conversation

StorytellerCZ
Copy link
Collaborator

Added Apollo skeleton based on the React skeleton and updated dependencies on all skeletons.
It is a very simple Apollo integration without anything fancy using the official apollo package.
Maybe in the future it might be a good idea to have more diversity in Apollo skeletons, but I think this is a much needed start of that process.

Copy link
Collaborator

@filipenevola filipenevola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok moving forward with this version but we have many different ways to integrate with Apollo, in my projects I don't use like this. But I'm ok with this approach.

I'm still torn between examples or more skeletons, this case seems to be more a example than a skeleton as you are selecting React already as the view layer. For Cordova, as I'm making a lot of choices as well, I'm going with example #11072

What do you think?

tools/static-assets/skel-apollo/imports/ui/Info.jsx Outdated Show resolved Hide resolved
Co-authored-by: Filipe Névola <filipe@quave.com.br>
@StorytellerCZ
Copy link
Collaborator Author

@filipenevola I have written an article on my thinking on Dev.to: https://dev.to/storytellercz/meteor-create-apollo-32e2
In short I see this as the basic HTTP GraphQL skeleton that most developers are familiar with (plus React). I think additional skeletons around Apollo should be coming in next version. I see something like apollo-ddp, to integrate the benefits of DDP, as the one with most interest from Meteor community. This skeleton though is targeted at new comers.

@StorytellerCZ
Copy link
Collaborator Author

I'll make another round of updating the skeletons dependencies tomorrow.

@filipenevola filipenevola added this to the Release 1.10.3 milestone Aug 10, 2020
@filipenevola
Copy link
Collaborator

Thanks @StorytellerCZ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants