Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Support email attachments #1114

Merged
merged 0 commits into from

3 participants

@ryw

@glasser I'm not sure what needs to change in the _.each for attachments in packages/email/email.js to support binary attachments, so I updated comment.

With some guidance, I'd be happy to do what is needed to support binaries.

Once code supports binary attachments, I'll update email_tests.js. Considering we'd then be supporting both text + binary attachments, should we make make new test examples, or would you prefer just adding to the test one ascii and one binary attachment?

@ryw
ryw commented

@glasser any thoughts on this? I'll jump in to get this PR in order, just need a few questions answered...

@glasser
Owner

Maybe this is worth looking at once we've released @estark37 's Assets API, since that's probably the best way to actually get binary assets into Meteor code.

EJSON binary objects are actually just Uint8Arrays.

@estark37 estark37 merged commit 2e78d0d into from
@ericpedia ericpedia referenced this pull request from a commit
@glasser glasser Attachment support for Email.send.
Only supports specifying contents as base64-encoded strings, which is not a
great interface; we should implement Meteor Buffers.
763a442
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Sorry, commit information is not available for this pull request.

Something went wrong with that request. Please try again.