Support email attachments #1114

Merged
merged 0 commits into from Jul 29, 2013

Projects

None yet

3 participants

@ryw
Contributor
ryw commented May 30, 2013

@glasser I'm not sure what needs to change in the _.each for attachments in packages/email/email.js to support binary attachments, so I updated comment.

With some guidance, I'd be happy to do what is needed to support binaries.

Once code supports binary attachments, I'll update email_tests.js. Considering we'd then be supporting both text + binary attachments, should we make make new test examples, or would you prefer just adding to the test one ascii and one binary attachment?

@ryw
Contributor
ryw commented Jun 5, 2013

@glasser any thoughts on this? I'll jump in to get this PR in order, just need a few questions answered...

@glasser
Member
glasser commented Jun 10, 2013

Maybe this is worth looking at once we've released @estark37 's Assets API, since that's probably the best way to actually get binary assets into Meteor code.

EJSON binary objects are actually just Uint8Arrays.

@estark37 estark37 merged commit 2e78d0d into meteor:devel Jul 29, 2013

1 check passed

default The author has signed the Meteor Contributor Agreement.
Details
@ericpedia ericpedia referenced this pull request Mar 7, 2014
@glasser glasser Attachment support for Email.send.
Only supports specifying contents as base64-encoded strings, which is not a
great interface; we should implement Meteor Buffers.
763a442
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment