When cordova add plugin fails using the id in the git URL we now retry using the plugin name #11202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
namenotrequired
approved these changes
Oct 6, 2020
tools/cordova/project.js
Outdated
| commandOptions)); | ||
| } catch (error) { | ||
| if (retry && utils.isUrlWithSha(version)) { | ||
| Console.warn(`plugin add for ${id} failed with plugin id in \ |
There was a problem hiding this comment.
The indentation is causing random spaces in the message
(Also, tinyest of nitpicks, but the other log messages start with a capital letter, I think it improves readability)
…y using the plugin name. Fixes #11199
…y using the plugin name. - improve logs
…y using the plugin name. - history.md
filipenevola
force-pushed
the
cordova-plugin-add-url-id
branch
from
79db7c9
to
903ba00
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11199