New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Cordova to 10.0.0 #11208
Update Cordova to 10.0.0 #11208
Conversation
Thanks for this! Awesome work! |
Great work! |
I was able to replicate the issue locally and push an update. |
@@ -16,13 +16,13 @@ export const CORDOVA_PLATFORMS = ['ios', 'android']; | |||
export const CORDOVA_DEV_BUNDLE_VERSIONS = { | |||
'cordova-lib': '10.0.0', | |||
'cordova-common': '4.0.2', | |||
'cordova-create': '3.0.0', | |||
'cordova-create': '2.0.0', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it a downgrade @costinelmarin? if we don't have a strong reason to downgrade, we probably should not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@renanccastro the android platform was not working with 'cordova-create': '3.0.0'
. I was able to make it work locally by using 2.0.0
version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why wasn't it working? maybe we have another solution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the dependency were not installed, properties-parser
package and when adding android platform I get this message %% cordova-android version check failed (project/.meteor/local/cordova-build/platforms/android/cordova/version), continuing anyways.
.
@renanccastro can we get more details why the travis build failed? |
@costinelmarin the problem on Travis was a timeout, I'm running it again. |
Hey @filipenevola. It is possible to run the Travis again and release in the next meteor version if the tests pass? |
@renanccastro & @costinelmarin |
is launchScreens [https://docs.meteor.com/api/mobile-config.html#App-launchScreens] also updated to cordova-10? I have issue with iOS as configuration has changed [https://cordova.apache.org/docs/en/latest/reference/cordova-plugin-splashscreen/index.html#ios-specific-information]. |
No description provided.