Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cordova to 10.0.0 #11208

Merged
merged 5 commits into from Mar 18, 2021
Merged

Update Cordova to 10.0.0 #11208

merged 5 commits into from Mar 18, 2021

Conversation

costinelmarin
Copy link
Contributor

No description provided.

@renanccastro
Copy link
Contributor

Thanks for this! Awesome work!
The tests are outputting the following when creating new Cordova apps:
"Error: Cannot find module 'properties-parser'"
We are probably missing dependencies from cordova-create, since they have split the cordova-lib.

@filipenevola filipenevola added this to the Release 2.0 milestone Oct 15, 2020
@filipenevola filipenevola added Project:Mobile pending-tests Tests are not passing, stuck or we need new tests hacktoberfest-accepted labels Oct 28, 2020
@filipenevola filipenevola modified the milestones: Release 2.0, Release 2.1 Jan 12, 2021
@Nauzer
Copy link
Contributor

Nauzer commented Feb 3, 2021

Great work!
How can I help in getting this production ready?

@costinelmarin
Copy link
Contributor Author

I was able to replicate the issue locally and push an update.

@@ -16,13 +16,13 @@ export const CORDOVA_PLATFORMS = ['ios', 'android'];
export const CORDOVA_DEV_BUNDLE_VERSIONS = {
'cordova-lib': '10.0.0',
'cordova-common': '4.0.2',
'cordova-create': '3.0.0',
'cordova-create': '2.0.0',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it a downgrade @costinelmarin? if we don't have a strong reason to downgrade, we probably should not.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@renanccastro the android platform was not working with 'cordova-create': '3.0.0'. I was able to make it work locally by using 2.0.0 version.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why wasn't it working? maybe we have another solution.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the dependency were not installed, properties-parser package and when adding android platform I get this message %% cordova-android version check failed (project/.meteor/local/cordova-build/platforms/android/cordova/version), continuing anyways..

@costinelmarin
Copy link
Contributor Author

@renanccastro can we get more details why the travis build failed?
Thanks!

@filipenevola
Copy link
Collaborator

@costinelmarin the problem on Travis was a timeout, I'm running it again.

@filipenevola filipenevola modified the milestones: Release 2.1, Release 2.2 Feb 25, 2021
@costinelmarin
Copy link
Contributor Author

costinelmarin commented Mar 1, 2021

Hey @filipenevola. It is possible to run the Travis again and release in the next meteor version if the tests pass?
Thanks!

@shahdeep1989
Copy link

shahdeep1989 commented Mar 5, 2021

@renanccastro & @costinelmarin
Can I expect this changes in next meteor release in meteor 2.2? If yes when?
When can I expect cordova-android from 8.1.0 to >=9.0.0?

@filipenevola filipenevola changed the base branch from devel to cordova-10 March 17, 2021 20:51
@filipenevola filipenevola changed the base branch from cordova-10 to release-2.2 March 18, 2021 00:55
@filipenevola filipenevola merged commit 2389ce0 into meteor:release-2.2 Mar 18, 2021
19 checks passed
@mjcctech
Copy link

is launchScreens [https://docs.meteor.com/api/mobile-config.html#App-launchScreens] also updated to cordova-10? I have issue with iOS as configuration has changed [https://cordova.apache.org/docs/en/latest/reference/cordova-plugin-splashscreen/index.html#ios-specific-information].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted pending-tests Tests are not passing, stuck or we need new tests Project:Mobile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants