Update Typescript to 4.0.5 #11225
Merged
Update Typescript to 4.0.5 #11225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipenevola
commented
Oct 28, 2020
| @@ -373,12 +373,12 @@ export const blankHash = "47DEQpj8HBSa+/TImW+5JCeuQeRkm5NMpJWZG3hSuFU="; | |||
| // Returns a base64 SHA256 hash representing a tree on disk. It is not sensitive | |||
| // to modtime, uid/gid, or any permissions bits other than the current-user-exec | |||
| // bit on normal files. | |||
| export function treeHash(root: string, options: { | |||
| ignore: (path: string) => boolean; | |||
| export function treeHash(root: string, optionsParams: { | |||
There was a problem hiding this comment.
@afrokick can you review my change? I'm not a TS expert but I did the change based on my general knowledge ;) It was breaking with TS2783 error
afrokick
reviewed
Oct 28, 2020
| @@ -14,8 +14,8 @@ var packageJson = { | |||
| pacote: "https://github.com/meteor/pacote/tarball/a81b0324686e85d22c7688c47629d4009000e8b8", | |||
| "node-gyp": "6.0.1", | |||
| "node-pre-gyp": "0.14.0", | |||
| typescript: "3.8.3", | |||
| "meteor-babel": "7.9.0", | |||
| typescript: "4.0.5", | |||
There was a problem hiding this comment.
also we need to update meteor-babel's TS to 4.0.5 https://github.com/meteor/babel/blob/master/package.json#L50
filipenevola
added
in-development
|
Windows tests are getting stuck, not sure why. I'll merge it and so we can see the tests in the release-1.12 branch. |
filipenevola
added
confirmed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #11154