Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Meteor.disconnect() to allow user disconnection of streams. #1151

Closed
wants to merge 7 commits into from

Conversation

@zol
Copy link
Contributor

@zol zol commented Jun 14, 2013

As outlined in this discussion it may occasionally be necessary for the user to disconnect the current stream.

This pull request adds a disconnect method to _DdpClientStream that is modelled on forceDisconnect(). The difference being that it sets the status to 'offline' and allows the user to call reconnect() on the stream later. It also plumbs disconnect into the Meteor. namespace.

Some rudimentary tests are included and the feature has been manually tested to work.

@caseycobb
Copy link

@caseycobb caseycobb commented Jun 25, 2013

This is so cool.

@n1mmy
Copy link
Member

@n1mmy n1mmy commented Jul 24, 2013

Reviewed and tested. Looks good! Thanks, @zol. I've got a rebased version on the pr-1151 branch.

Only thing missing I think is docs. Can you whip up some quick docs, including a new entry for Meteor.disconnected and a description of the offline state in Meteor.status?

@zol
Copy link
Contributor Author

@zol zol commented Jul 24, 2013

Sweet, thanks for merging that @n1mmy. I'll crank out some docs tomorrow.

On Tuesday, 23 July 2013 at 11:44 PM, Nick Martin wrote:

Reviewed and tested. Looks good! Thanks, @zol (https://github.com/zol). I've got a rebased version on the pr-1151 branch.
Only thing missing I think is docs. Can you whip up some quick docs, including a new entry for Meteor.disconnected and a description of the offline state in Meteor.status?


Reply to this email directly or view it on GitHub (#1151 (comment)).

@zol
Copy link
Contributor Author

@zol zol commented Jul 24, 2013

@n1mmy docs are ready to go.

@n1mmy
Copy link
Member

@n1mmy n1mmy commented Jul 26, 2013

Merged in 8c65272. Thanks, zol!

@n1mmy n1mmy closed this Jul 26, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.