Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub OAuth allow_signup & more data returned #11724

Merged
merged 16 commits into from Feb 11, 2022

Conversation

StorytellerCZ
Copy link
Collaborator

Two new features for GitHub OAuth.

  1. Based on Accounts config pass in allow_signup param on the initial request to prevent sign ups on GitHub side if the user does not have an account already.
  2. After data about the user is retrieved get more of it into serviceData so that they are available to the app. We will receive the data anyway, so might as well use it.

@StorytellerCZ StorytellerCZ added this to the Release 2.6 milestone Oct 27, 2021
@filipenevola filipenevola removed this from the Release 2.6 milestone Jan 21, 2022
packages/github-oauth/github_client.js Outdated Show resolved Hide resolved
Co-authored-by: Denilson <denilsonh2014@gmail.com>
renanccastro and others added 4 commits February 8, 2022 11:07
Remove throw on _id exclusion inside mongo collection finds
The static-html package is in the meteor/meteor repo.
@denihs denihs changed the base branch from devel to release-2.6.1 February 9, 2022 21:46
@denihs denihs added this to the Release 2.6.1 milestone Feb 9, 2022
@github-actions github-actions bot temporarily deployed to pull request February 10, 2022 14:36 Inactive
@denihs denihs merged commit 6d58f37 into release-2.6.1 Feb 11, 2022
@github-actions github-actions bot temporarily deployed to pull request February 11, 2022 19:07 Inactive
@StorytellerCZ StorytellerCZ deleted the feature/github-return-data branch February 11, 2022 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants