New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Underscore.string.js smart package #119

Closed
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
5 participants
@antoviaque

antoviaque commented May 1, 2012

Adds string manipulation helpers such as _.str.trim(), _.str.capitalize(), etc.

Cf https://github.com/edtsech/underscore.string

@jasonLaster

This comment has been minimized.

jasonLaster commented May 10, 2012

Man, i'm looking forward to this merge :)

@nickythegreek

This comment has been minimized.

nickythegreek commented May 14, 2012

yes please!

@audreyr

This comment has been minimized.

Contributor

audreyr commented Aug 8, 2012

Hey there, you'll need to submit a CLA (contributor license agreement) before we can review your pull request. Can you please visit http://contribute.meteor.com/, fill out the form, and comment here when you're done? Thanks!

@patrickdevivo

This comment has been minimized.

patrickdevivo commented Aug 8, 2012

+1!

@audreyr

This comment has been minimized.

Contributor

audreyr commented Aug 8, 2012

Lots of pressure on you now to get that CLA in, @antoviaque ;)

@antoviaque

This comment has been minimized.

antoviaque commented Aug 9, 2012

Hi Audrey! I don't want to be the troublemaker, but I'm actually a bit uncomfortable signing licensing agreements. : )

Cf #87 where I was asking to be able to release work to you under the MIT license, to give you all the assurances you need about my code without the overly broad terms of a licensing agreement (see #87 for links to articles from several well-known open source/free software personalities on the topic).

But this shouldn't be a blocker for this pull request btw - my contribution here is ~3 lines copy-pasted & edited from other packages, that's not enough to be an "original work of authorship", I don't really have copyright claims on this - the real contribution here is the Underscore.string.js code (which, unless you get the Underscore.string.js author to sign the agreement, you'd have to take under the terms of their license).

Hope I'm not too much of a pain here... But history has shown that it's a topic on which it's best to be cautious as a developer. Hope you understand!

@audreyr

This comment has been minimized.

Contributor

audreyr commented Aug 13, 2012

Hey :) Completely unrelated to the CLA, we've decided to add a new "Package Submission Guideline" that relates to this: "Similarly, the bar is higher for new packages that only include JS files with minimal integration. Generally, the test is whether a file can simply be put into your project's lib or server/lib directory, or if additional effort is needed to make it work."

Since underscore.string.js is a file that can be dropped into lib easily without further integration, and since none of core Meteor uses underscore.string.js at this time, I'm closing this one out.

As for the CLA issue, I'll post directly in #87 shortly.

Nice virtually meeting you in IRC the other day! As always, if you have other thoughts/comments/suggestions about the CLA, this pull request, or anything else, feel free to ping me anytime.

@audreyr audreyr closed this Aug 13, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment