Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Underscore.string.js smart package #119
Hi Audrey! I don't want to be the troublemaker, but I'm actually a bit uncomfortable signing licensing agreements. : )
Cf #87 where I was asking to be able to release work to you under the MIT license, to give you all the assurances you need about my code without the overly broad terms of a licensing agreement (see #87 for links to articles from several well-known open source/free software personalities on the topic).
But this shouldn't be a blocker for this pull request btw - my contribution here is ~3 lines copy-pasted & edited from other packages, that's not enough to be an "original work of authorship", I don't really have copyright claims on this - the real contribution here is the Underscore.string.js code (which, unless you get the Underscore.string.js author to sign the agreement, you'd have to take under the terms of their license).
Hope I'm not too much of a pain here... But history has shown that it's a topic on which it's best to be cautious as a developer. Hope you understand!
Hey :) Completely unrelated to the CLA, we've decided to add a new "Package Submission Guideline" that relates to this: "Similarly, the bar is higher for new packages that only include JS files with minimal integration. Generally, the test is whether a file can simply be put into your project's
Since underscore.string.js is a file that can be dropped into
As for the CLA issue, I'll post directly in #87 shortly.
Nice virtually meeting you in IRC the other day! As always, if you have other thoughts/comments/suggestions about the CLA, this pull request, or anything else, feel free to ping me anytime.