Move some OAuth of out of accounts-base #12202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix tests and move few things back.
|
We are making some changes in the accounts(adding async) I think it makes sense to move this change to 2.9. but I'm all ears if you want this could go in a patch for 2.8.x |
|
Let's merge this into 2.9. |
# Conflicts: # docs/history.md
|
@denihs this will require a bit of a testing during the beta release phase to make sure that I haven't missed some use case and that with all the other changes going on around that nothing has been missed or overridden. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the discussion in #12171 I have taken the initiative and moved some OAuth related code out of
accounts-baseintoaccounts-oauth.I have also added some additional conditionals in 6196453, which can be cherry picked if needed, which might have caused the error seen in #12171.