Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the option to use a hosted domain with google's oauth #1332

Closed
wants to merge 1 commit into from

Conversation

@ansman
Copy link
Contributor

@ansman ansman commented Aug 18, 2013

The hd option is used to restrict which email domain that are allowed to
log in to your app.

Starting from this commit you can pass hostedDomain: 'example.com' to
only allow emails from the domain example.com.

The hd option is used to restrict which email domain that are allowed to
log in to your app.

Starting from this commit you can pass `hostedDomain: 'example.com'` to
only allow emails from the domain `example.com`.
@apollo-cla
Copy link

@apollo-cla apollo-cla commented Aug 18, 2013

@ansman: Before we can merge your pull request, you'll need to sign the Meteor Contributor Agreement: https://contribute.meteor.com/

@glasser
Copy link
Member

@glasser glasser commented Aug 19, 2013

This is relevant to #765.

@glasser
Copy link
Member

@glasser glasser commented Aug 19, 2013

Because this is client-side-only, you really want to check on the server-side too. And this should probably go into Accounts.config.

#765 (comment)

@avital avital mentioned this pull request Sep 26, 2013
@Slava
Copy link
Member

@Slava Slava commented Sep 26, 2013

Looks like hd argument is depricated: https://developers.google.com/accounts/docs/OAuth_ref, anyone knows what is the new way to set it?

@meawoppl
Copy link
Contributor

@meawoppl meawoppl commented Sep 26, 2013

There are some relevant comments here. In short, it seems that lots of people report the 'hd=" parameter to be working with oauth2, however it is unclear why it is not in the documentation (omission vs. non-support).

Another report of success using the hd paramater can be found in this discussion, which mirrors similar confusion by the situation: "Would anybody be able to answer if this is an undocumented feature that's here to stay?"

@Slava
Copy link
Member

@Slava Slava commented Sep 26, 2013

Hi, @meawoppl,

Thank you for the links. hd argument is now passed if you specify it in Accounts.config (I can't report it working though).

@Slava
Copy link
Member

@Slava Slava commented Sep 26, 2013

Hey @ansman, thanks for your PR, merged to devel with additional checks on the server-side according to @glasser's comments. Closing.

@Slava Slava closed this Sep 26, 2013
@ansman
Copy link
Contributor Author

@ansman ansman commented Sep 26, 2013

Thanks.

@meawoppl
Copy link
Contributor

@meawoppl meawoppl commented Sep 26, 2013

I will test as soon as it makes the a numbered release. Thanks.

@Slava
Copy link
Member

@Slava Slava commented Sep 27, 2013

@meawoppl thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.