New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for err.stack in logErr in wrapAsync #1387

Merged
merged 1 commit into from Sep 2, 2013

Conversation

Projects
None yet
2 participants
@mitar
Collaborator

mitar commented Aug 31, 2013

err has already true value at that point, so we probably want to check if there is err.stack available. Otherwise code can be simplified in another way.

@estark37

This comment has been minimized.

Contributor

estark37 commented Sep 2, 2013

Thanks @mitar, that was indeed definitely supposed to be a check for err.stack.

estark37 added a commit that referenced this pull request Sep 2, 2013

Merge pull request #1387 from peerlibrary/wrapasync-err
Check for err.stack in logErr in wrapAsync

@estark37 estark37 merged commit 1c8a516 into meteor:devel Sep 2, 2013

1 check passed

default The author has signed the Meteor Contributor Agreement.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment