New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excluded appcache paths are being counted by sizeCheck function #1653

Closed
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
4 participants
@dburles
Contributor

dburles commented Dec 4, 2013

I noticed as I was adding paths to exclude from the cache the calculated total wouldn't change to reflect this.

Edit: Sorry. Ignore the PR.

@meteor-bot

This comment has been minimized.

meteor-bot commented Dec 4, 2013

@dburles: Before we can merge your pull request, you'll need to sign the Meteor Contributor Agreement: https://contribute.meteor.com/

@n1mmy n1mmy closed this in 1eff62f Dec 6, 2013

@n1mmy

This comment has been minimized.

Member

n1mmy commented Dec 6, 2013

Good catch. Thanks, @dburles

@dburles

This comment has been minimized.

Contributor

dburles commented Dec 6, 2013

Hey @n1mmy thanks, though I wasn't completely confident in my patch that it was actually the correct solution! It appears though that it was?

@n1mmy

This comment has been minimized.

Member

n1mmy commented Dec 6, 2013

Yeah, I'm pretty sure it's correct.

@n1mmy n1mmy referenced this pull request Feb 20, 2014

Closed

AppCache size calculation #1847

@cdoe

This comment has been minimized.

cdoe commented Apr 28, 2014

It seems like resource.cacheable was changed to RoutePolicy.classify(resource.url) in more recent versions.

My onlineOnly config files still seem to contribute to the sizeCheck() size.

I can't see why RoutePolicy.classify() would exclude non-cached items from the size check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment