Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle exception when IE has too tight security settings on window.local... #1688

Closed
wants to merge 1 commit into from
Closed

Handle exception when IE has too tight security settings on window.local... #1688

wants to merge 1 commit into from

Conversation

@ghost
Copy link

@ghost ghost commented Dec 16, 2013

...Storage

In IE, the application crashes when the security settings don't allow window.localStorage to be accessed

…calStorage

In IE, the application crashes when the security settings don't allow window.localStorage to be accessed
@raix
Copy link
Contributor

@raix raix commented Dec 16, 2013

Checkout #1291 Theres a thread about this

Loading

@glasser
Copy link
Member

@glasser glasser commented Dec 19, 2013

It's not a PR, but @piffie posted this gist: https://gist.github.com/piffie/7944268

That's a good approach: it tries to actually use localstorage a bit before deciding that it exists. We should take a patch based on @piffie's concept, I think.

Loading

glasser added a commit that referenced this issue Dec 20, 2013
Fixes accounts-password login with private-browsing Safari, and probably
some IE configurations too.

Fixes #1291 (I hope, not tested on IE). Similar to #1688.

This still means that multi-tab won't work with private browsing, unfortunately.
@glasser
Copy link
Member

@glasser glasser commented Dec 20, 2013

I pushed a version of @piffie's patch: 3f12f77

I didn't test on IE, but it helps private-browsing Safari. If folks with IE can check to see if this fixes their issue, let me know! (That said, you still lose your login when you hit refresh or open a new tab.)

Loading

@glasser glasser closed this Dec 20, 2013
@mizzao
Copy link
Contributor

@mizzao mizzao commented Jun 2, 2014

@glasser: not fixed on IE - see #1291 (comment).

I have a machine on which this error manifests and I'd be happy to show it to you when I'm in SF next week.

Loading

mizzao added a commit to scienceathome/meteor that referenced this issue Jun 2, 2014
…ixes meteor#1688.

Accessing `window.localStorage` can immediately throw an exception, which needs to be caught.
For more information, see http://www.w3.org/TR/webstorage/#dom-localstorage.
@mizzao
Copy link
Contributor

@mizzao mizzao commented Jun 2, 2014

#2204 allows the shim to work properly in IE.

Loading

mizzao added a commit to scienceathome/meteor that referenced this issue Jun 2, 2014
…meteor#1688.

Accessing `window.localStorage` can immediately throw an exception, which needs to be caught.
For more information, see http://www.w3.org/TR/webstorage/#dom-localstorage.
Slava added a commit that referenced this issue Jun 9, 2014
Accessing `window.localStorage` can immediately throw an exception, which needs to be caught.
For more information, see http://www.w3.org/TR/webstorage/#dom-localstorage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants