Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Nib support to the Stylus package #175

Closed
wants to merge 42 commits into from
Closed

Adding Nib support to the Stylus package #175

wants to merge 42 commits into from

Conversation

@TrevorBurnham
Copy link
Contributor

@TrevorBurnham TrevorBurnham commented Jun 10, 2012

This patch throws in Nib to complement the existing Stylus package. Stylus requires this support to be added programmatically, but Nib is 100% opt-in: Just add

@import 'nib'

at the top of a .styl file to enable it. Once enabled, Nib automatically converts lines like

background: linear-gradient(top, hsl(55, 100%, 80%), hsl(55, 100%, 70%))

into the more widely-supported

background: -webkit-gradient(linear, left top, left bottom, color-stop(0, #fff799), color-stop(1, #fff266));
background: -webkit-linear-gradient(top, #fff799 0%, #fff266 100%);
background: -moz-linear-gradient(top, #fff799 0%, #fff266 100%);
background: -o-linear-gradient(top, #fff799 0%, #fff266 100%);
background: -ms-linear-gradient(top, #fff799 0%, #fff266 100%);
background: linear-gradient(top, #fff799 0%, #fff266 100%);

I've also bumped Stylus to its latest version.

I apologize for the lack of tests, but I haven't been able to figure out a way to implement them in a browser-independent way. getComputedStyle won't give you a value for vendor-prefixed property names. Suffice to say that I've installed Meteor with this patch on my system and it's working smoothly.

Really enjoyed your presentation at FluentConf, by the way. :)

mpj and others added 30 commits Apr 25, 2012
… has many tabs open. "Meteor" gets confusing when you have both the documentation, and say, the examples open at the same time, as they are both titled "Meteor".
If the initial _doPoll didn't complete before the first markDirty, two doPolls could be running at once, causing badness.
Updated title on the documentation
@n1mmy
Copy link
Member

@n1mmy n1mmy commented Jun 19, 2012

Thanks! This patch looks good. Can you please sign the Meteor CLA at http://contribute.meteor.com/ so we can accept the pull request?

@ghost ghost assigned n1mmy Jun 19, 2012
@TrevorBurnham
Copy link
Contributor Author

@TrevorBurnham TrevorBurnham commented Jun 19, 2012

Done.

@n1mmy
Copy link
Member

@n1mmy n1mmy commented Jun 20, 2012

Thanks. Merged to dev-bundle-bump branch. I'm gonna hold off for some other dev bundle changes before bumping the version number and merging to devel.

@debergalis debergalis closed this Jul 13, 2012
@debergalis
Copy link
Member

@debergalis debergalis commented Jul 13, 2012

It's on devel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants