Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Optionally pass in 'html' template function to Accounts email templates #1785
PR against #1784 . Do you guys agree with the approach I've used here, that is making 'text' emails required and 'html' optional?
This is the last piece of functionality on our fork of Meteor that's not yet integrated into mainline, it would be awesome to see it merged.
@glasser could you please give me some more guidance - in particular, point me to a specific function somewhere in else in the codebase you'd like me to model tests off. The tests in
Hrm, I'd kinda like to see tests. This is the sort of thing we can break pretty easily without tests. It would be good to see that the functions run and they have the right arguments, like we do for the default text functions, and I don't think its too hard.
I think this looks like:
I'm not so worried that the template config is global. No one else is going to be testing this email sending, and if they are they probably shouldn't be sensitive to the presence of the html option to intercepted emails. If we're extra fancy we could have some shared state like
added a commit
this pull request
Mar 13, 2014
@lorensr I don't think this is the right place to discuss it, but I believe text is used by email clients that don't support html.
Edit: think I found a great link: http://blog.hubspot.com/blog/tabid/6307/bid/32643/Why-Marketers-Must-Optimize-Emails-for-HTML-AND-Plain-Text-Infographic.aspx