Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check static cacheable dir exists before using gzippo #179

Closed
wants to merge 1 commit into from
Closed

check static cacheable dir exists before using gzippo #179

wants to merge 1 commit into from

Conversation

@ibash
Copy link
Contributor

@ibash ibash commented Jun 12, 2012

When gzippo can't find the directory, it serves an empty file. This checks whether the static_cacheable directory exists before using gzippo for it. related issue

To reproduce the problem / solution.
from your meteor repo

cd docs
../meteor

and then load localhost:3000 from a browser with a clean cache, you should be prompted to download an empty file if you don't have the change.

@n1mmy
Copy link
Member

@n1mmy n1mmy commented Jun 19, 2012

Thanks! This looks good. Can you please sign the CLA at http://contribute.meteor.com/ so we can accept the pull request?

@ibash
Copy link
Contributor Author

@ibash ibash commented Jun 19, 2012

@n1mmy signed

@n1mmy
Copy link
Member

@n1mmy n1mmy commented Jun 20, 2012

Thanks! Merged in eb8a847

@n1mmy n1mmy closed this Jun 20, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants