Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Maintain file modes when copying a directory. #1808
I mean, this does look strictly better, but I want to understand the end-to-end use case where this is observable, because if we fix this and users rely on the behavior, then we want to make sure not to break it later (eg, there are multiple steps in bundling, some of them might use a different function, etc).
I guess your use case is including an executable as a server-side asset (eg the
Can you say more about what exactly you're trying to accomplish? I'm just imagining writing a test for this fix and realizing that it seems like I'd have to do something that we don't provide an API for.
My particular use case is actually simpler than what you mention. I'm trying to create a package for the closure compiler, for which there already exists a node module. That module bundles a Java distribution in case there is no global Java installation (or if the global Java is outdated). The Meteor bundler is throwing away execute privileges on the module's own bundled Java.
So clearly you can hit this in a test by relying on a node module that itself relies on an executable, which seems legal as far as Meteor is concerned.