Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recognize forceApprovalPrompt option in Accounts.ui.config #2149

Closed
wants to merge 6 commits into from

Conversation

rcy
Copy link
Contributor

@rcy rcy commented May 15, 2014

this option was originally added via #1226

@@ -56,9 +57,22 @@ Accounts.ui.config = function(options) {
}
});
}

// deal with `forceApprovalPrompt`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's OK if you don't deal with this in this PR, but there's now a whole lot of duplicated code in this file. Can you add a comment reading

  // XXX refactor duplicated code in this function

@glasser
Copy link
Contributor

glasser commented May 22, 2014

This looks good but it will need an update to the docs for Accounts.ui.config, in docs/client/api.js.

@rcy
Copy link
Contributor Author

rcy commented Jun 25, 2014

@glasser I made the 2 changes you recommended (adding refactor note, and the documentation update)

@glasser
Copy link
Contributor

glasser commented Jul 22, 2014

Thanks, merged. (Sorry for the delay, catching up from vacation.)

@glasser glasser closed this Jul 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants