Removed no longer needed hack #2216
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Cangit. Can you please list the examples you test this change on? |
|
This is an example in its purest form Error should be reported to line 5, but error message reads like this: |
| @@ -44,7 +44,7 @@ Plugin.registerSourceHandler("less", function (compileStep) { | |||
| compileStep.error({ | |||
| message: "Less compiler error: " + e.message, | |||
| sourcePath: e.filename || compileStep.inputPath, | |||
| line: e.line - 1, // dunno why, but it matches | |||
| line: e.line, | |||
| column: e.column + 1 | |||
There was a problem hiding this comment.
Is the +1 still needed?
|
@mquandalle Yes, the +1 to column is still needed. |
|
I figured out when this behaviour changed, in less 1.6 released january 1st 2014. ref: https://github.com/less/less.js/blob/master/CHANGELOG.md#160 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hack done here: https://github.com/meteor/meteor/blob/devel/packages/less/plugin/compile-less.js#L47
now backfires on my system and is reporting a line number one less than the actual error. I don't know when this behaviour has changed, but I have tested this in multiple scenarios.
(I also see that the less library package is a bit outdated.)