New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assure that transform is not changing cached object #2231

Closed
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
2 participants
@mitar
Collaborator

mitar commented Jun 12, 2014

Fix for #2026.

mitar added a commit to peerlibrary/meteor-peerdb that referenced this pull request Jun 12, 2014

Revert "Made objectify idempotent."
This reverts commit 09db486.

This is not necessary after this bugfix in Meteor:
meteor/meteor#2231
@glasser

This comment has been minimized.

Member

glasser commented Jun 18, 2014

Good catch. It would be more consistent with the rest of the file to move the EJSON.clone into the transform call (and that would make it more clear that the clone is for transform's sake).

@glasser

This comment has been minimized.

Member

glasser commented Jul 22, 2014

OK, I was thinking you'd update the PR based on my comment, but I did it myself and merged it. Thanks!

@glasser glasser closed this Jul 22, 2014

@mitar

This comment has been minimized.

Collaborator

mitar commented Jul 22, 2014

Oh, sorry. :-(

@mitar

This comment has been minimized.

Collaborator

mitar commented Jul 22, 2014

Should there be tests made for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment