Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed mouseenter/mouseleave #224

Closed
wants to merge 1 commit into from
Closed

Conversation

@ashaffer
Copy link

@ashaffer ashaffer commented Jul 10, 2012

Fixed broken mouseenter/mouseleave events. New code uses jQuery.contains, you may want to change this but the logic is correct.

@dgreensp
Copy link
Contributor

@dgreensp dgreensp commented Jul 12, 2012

Did I totally make up the "mousein" event?? Haha.

So, what is the logic around relatedTarget about? I'm not familiar with the subtlety here.

@dgreensp
Copy link
Contributor

@dgreensp dgreensp commented Jul 12, 2012

In anticipation of merging this, can you sign the CLA online? http://contribute.meteor.com/

Thanks!

@ashaffer
Copy link
Author

@ashaffer ashaffer commented Jul 12, 2012

Haha, ya I think you did. It does make sense though, mousein is the literal opposite of mouseout.

So, relatedTarget contains the element being entered in the case of a mouseout and the element being left in the case of a mouseover. So, if currentTarget (the element the event has been set on) contains relatedTarget, then from the perspective of a mouseenter/mouseleave event, nothing has changed.

Agreement signed.

@dgreensp dgreensp closed this in c3ecb78 Jul 12, 2012
@dgreensp
Copy link
Contributor

@dgreensp dgreensp commented Jul 13, 2012

Merged. Thanks for providing the proper logic for simulating these, I hadn't seen it before. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants