Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Remove sourcemap linking with a `//#` comment #2385
Thanks for noticing!
This looks incomplete:
Additionally, this is a good time figure out:
Can you make these updates and research the other issues? Definitely would love to get this cleanup in (perhaps after 0.9.0).
Thanks for the review @glasser. I've updated my PR to remove dead code & comments, and to use the new recommended source map header. It seems that Safari 7 and IE11 both support source maps but I haven't had a chance to verify it since I'm a happy linux user :)
I tested this with FF 32 and your second commit (changing from X-SourceMap to SourceMap) seems to have broken it. Are you sure it works on FF with SourceMap?
It did seem to work on Chrome and Safari with either header. So let's just take your first commit, and leave X-SourceMap with a different comment.