Improve test error readability #255

Merged
merged 5 commits into from Nov 3, 2012

Conversation

Projects
None yet
3 participants
@possibilities
Contributor

possibilities commented Aug 2, 2012

@avital

This comment has been minimized.

Show comment
Hide comment
@avital

avital Aug 3, 2012

Contributor

I'll run the tests on all the browsers.

Contributor

avital commented Aug 3, 2012

I'll run the tests on all the browsers.

@ghost ghost assigned avital Aug 3, 2012

@possibilities

This comment has been minimized.

Show comment
Hide comment
@possibilities

possibilities Aug 15, 2012

Contributor

@avital

Knowing what I know now I'm a little embarrassed about my initial shot at this.

This accomplishes the original goal of making the output a little bit easier on the eye without assuming certain keys are present in the fail object.

Thanks,
Mike

Contributor

possibilities commented Aug 15, 2012

@avital

Knowing what I know now I'm a little embarrassed about my initial shot at this.

This accomplishes the original goal of making the output a little bit easier on the eye without assuming certain keys are present in the fail object.

Thanks,
Mike

@possibilities

This comment has been minimized.

Show comment
Hide comment
@possibilities

possibilities Aug 15, 2012

Contributor

Oh right, new before and after given these failing tests

test.equal(5, 6, 'snap!');
test.isNull(1);
test.length([], 2);
moof();

Before and After

Contributor

possibilities commented Aug 15, 2012

Oh right, new before and after given these failing tests

test.equal(5, 6, 'snap!');
test.isNull(1);
test.length([], 2);
moof();

Before and After

packages/test-in-browser/driver.js
+
+ var prepare = function(details) {
+ return _.compact(_.map(details, function(val, key) {
+ if (!_.isUndefined(val))

This comment has been minimized.

@avital

avital Aug 20, 2012

Contributor

Do you know in which cases val is undefined here? If so can you add a comment for what those cases are?

@avital

avital Aug 20, 2012

Contributor

Do you know in which cases val is undefined here? If so can you add a comment for what those cases are?

packages/test-in-browser/driver.html
@@ -74,8 +74,12 @@
{{/if}}
{{#with get_details}}
{{#if this}}
- — {{this}}
+ {{#if type}}— {{type}}{{/if}}

This comment has been minimized.

@avital

avital Aug 20, 2012

Contributor

I know this isn't directly related to your change but can you please comment what the values of {{type}} can be here?

@avital

avital Aug 20, 2012

Contributor

I know this isn't directly related to your change but can you please comment what the values of {{type}} can be here?

This comment has been minimized.

@possibilities

possibilities Aug 22, 2012

Contributor
packages/test-in-browser/driver.css
-.test_table .event .xtimes { font-weight: bold; }
+
+.test_table .event .xtimes,
+.test_table .event .failkey

This comment has been minimized.

@avital

avital Aug 20, 2012

Contributor

Can you please follow the style of the other CSS rules on this page? That is -- one line statements when possible.

@avital

avital Aug 20, 2012

Contributor

Can you please follow the style of the other CSS rules on this page? That is -- one line statements when possible.

@possibilities

This comment has been minimized.

Show comment
Hide comment
@possibilities

possibilities Aug 22, 2012

Contributor

Addressed all of your comments.

Contributor

possibilities commented Aug 22, 2012

Addressed all of your comments.

@avital avital merged commit a7bbb8c into meteor:devel Nov 3, 2012

@avital

This comment has been minimized.

Show comment
Hide comment
@avital

avital Nov 3, 2012

Contributor

Finally got to this. There was a small bug when get_details runs the second time. Fixed on 62b5f1c.

Contributor

avital commented Nov 3, 2012

Finally got to this. There was a small bug when get_details runs the second time. Fixed on 62b5f1c.

@glasser

This comment has been minimized.

Show comment
Hide comment
@glasser

glasser Nov 4, 2012

Member

Glad to see this got in!

On Sat, Nov 3, 2012 at 11:09 AM, Avital Oliver notifications@github.comwrote:

Finally got to this. There was a small bug when get_details runs the
second time. Fixed on meteor/meteor@62b5f1chttps://github.com/meteor/meteor/commit/62b5f1c7ba87759d0e426b676c639406c20a1a43
.


Reply to this email directly or view it on GitHubhttps://github.com/meteor/meteor/pull/255#issuecomment-10042240.

Member

glasser commented Nov 4, 2012

Glad to see this got in!

On Sat, Nov 3, 2012 at 11:09 AM, Avital Oliver notifications@github.comwrote:

Finally got to this. There was a small bug when get_details runs the
second time. Fixed on meteor/meteor@62b5f1chttps://github.com/meteor/meteor/commit/62b5f1c7ba87759d0e426b676c639406c20a1a43
.


Reply to this email directly or view it on GitHubhttps://github.com/meteor/meteor/pull/255#issuecomment-10042240.

@possibilities

This comment has been minimized.

Show comment
Hide comment
@possibilities

possibilities Nov 4, 2012

Contributor

Me too. Sweet!
On Nov 3, 2012 8:12 PM, "David Glasser" notifications@github.com wrote:

Glad to see this got in!

On Sat, Nov 3, 2012 at 11:09 AM, Avital Oliver notifications@github.comwrote:

Finally got to this. There was a small bug when get_details runs the
second time. Fixed on 62b5f1c<
62b5f1c

.


Reply to this email directly or view it on GitHub<
https://github.com/meteor/meteor/pull/255#issuecomment-10042240>.


Reply to this email directly or view it on GitHubhttps://github.com/meteor/meteor/pull/255#issuecomment-10047000.

Contributor

possibilities commented Nov 4, 2012

Me too. Sweet!
On Nov 3, 2012 8:12 PM, "David Glasser" notifications@github.com wrote:

Glad to see this got in!

On Sat, Nov 3, 2012 at 11:09 AM, Avital Oliver notifications@github.comwrote:

Finally got to this. There was a small bug when get_details runs the
second time. Fixed on 62b5f1c<
62b5f1c

.


Reply to this email directly or view it on GitHub<
https://github.com/meteor/meteor/pull/255#issuecomment-10042240>.


Reply to this email directly or view it on GitHubhttps://github.com/meteor/meteor/pull/255#issuecomment-10047000.

@zol zol unassigned avital Feb 27, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment