Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/override from address #2858

Closed

Conversation

@netanelgilad
Copy link
Contributor

@netanelgilad netanelgilad commented Oct 19, 2014

This PR allows the overriding of the from field on the emaiTemplates.
I've opened a discussion on meteor-core https://groups.google.com/forum/#!topic/meteor-core/YB6-q54TB7U, but I wanted to also get some attention here, maybe someone is interested.

@glasser
Copy link
Member

@glasser glasser commented Dec 3, 2014

Please keep line lengths to 80 characters (https://github.com/meteor/meteor/wiki/Meteor-Style-Guide#line-length) and add tests to accounts-password/email_tests.js.

If you want to also fix #2854 in the way I suggested there while you're at, it be my guest :)

@netanelgilad
Copy link
Contributor Author

@netanelgilad netanelgilad commented Dec 5, 2014

@glasser Updated with tests and a fix for #2854 =]

@Urigo
Copy link
Contributor

@Urigo Urigo commented Dec 17, 2014

+1

1 similar comment
@davidyaha
Copy link

@davidyaha davidyaha commented Dec 17, 2014

+1

@glasser glasser closed this in a355dd2 Jan 26, 2015
meonkeys added a commit to meonkeys/meteor that referenced this pull request Feb 11, 2015
"meteor#2858" was interpreted by Markdown as <h1>2858</h1> instead of a
mention of GitHub ticket meteor#2858.
stubailo added a commit that referenced this pull request Feb 12, 2015
"#2858" was interpreted by Markdown as <h1>2858</h1> instead of a
mention of GitHub ticket #2858.
@glasser
Copy link
Member

@glasser glasser commented Mar 28, 2015

(Fixed in 1.0.4.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.