-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/override from address #2858
Closed
netanelgilad
wants to merge
9
commits into
meteor:devel
from
netanelgilad:feature/override-from-address
Closed
Feature/override from address #2858
netanelgilad
wants to merge
9
commits into
meteor:devel
from
netanelgilad:feature/override-from-address
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please keep line lengths to 80 characters (https://github.com/meteor/meteor/wiki/Meteor-Style-Guide#line-length) and add tests to If you want to also fix #2854 in the way I suggested there while you're at, it be my guest :) |
+1 |
1 similar comment
+1 |
meonkeys
added a commit
to meonkeys/meteor
that referenced
this pull request
Feb 11, 2015
"meteor#2858" was interpreted by Markdown as <h1>2858</h1> instead of a mention of GitHub ticket meteor#2858.
(Fixed in 1.0.4.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the overriding of the from field on the emaiTemplates.
I've opened a discussion on meteor-core https://groups.google.com/forum/#!topic/meteor-core/YB6-q54TB7U, but I wanted to also get some attention here, maybe someone is interested.