New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made query parameter available to oauth1 services #2894

Closed
wants to merge 2 commits into
base: devel
from

Conversation

Projects
None yet
2 participants
@andylash
Contributor

andylash commented Oct 24, 2014

In order to get the accounts_quickbooks and associated quickbooks package working, I had to get access to this realmId parameter that comes back in the oauth request. This seemed like simple and safe way to do it (and the oauth2 code already has access to the query parameter).

@andylash

This comment has been minimized.

Contributor

andylash commented Nov 7, 2014

@estark37 (Slava suggested I forward to you) - is this something you could take a look at? I'm pretty sure I need this code change to make the integration with quickbooks work, but maybe there's something I'm missing. Here's the rest of the quickbooks integration, if that helps.

https://github.com/andylash/accounts-quickbooks
https://github.com/andylash/quickbooks

Cheers,
andy

@estark37

This comment has been minimized.

Contributor

estark37 commented Nov 17, 2014

Hey @andylash, sorry for the slow response! This looks reasonable to me, but could we stick it in an options object instead? i.e. make the second argument { query: query }, instead of just query. That way we won't have to keep sticking arguments on the end if we end up needing to pass more information. Thanks!

@andylash

This comment has been minimized.

Contributor

andylash commented Nov 17, 2014

Sounds totally reasonable. I made the change

@estark37

This comment has been minimized.

Contributor

estark37 commented Nov 17, 2014

Thanks! Merged.

@estark37 estark37 closed this Nov 17, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment