Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spiderable support for hash fragments #2938

Closed
wants to merge 1 commit into from

Conversation

@awwx
Copy link
Contributor

@awwx awwx commented Oct 28, 2014

Since the browser application cache appears not to support URL path
routes in a non-buggy way (see
#2926), applications using the
appcache package will want to use hash fragment routes instead.

This PR adds support to the spiderable package for hash fragment
routes. An original URL such as http://example.com/#!a=1&b=2 will
be encoded by a search engine as an escaped fragment, decoded by the
spiderable package, passed through to the phantomjs process, and
appear to the phantom client as #!a=1&b=2 in window.location.hash
(the same as when the original URL is opened in a regular browser).

Since the browser application cache appears not to support URL path
routes in a non-buggy way (see
#2926), applications using the
appcache package will want to use hash fragment routes instead.

This PR adds support to the spiderable package for hash fragment
routes.  An original URL such as `http://example.com/#!a=1&b=2` will
be encoded by a search engine as an escaped fragment, decoded by the
spiderable package, passed through to the phantomjs process, and
appear to the phantom client as `#!a=1&b=2` in `window.location.hash`
(the same as when the original URL is opened in a regular browser).
@glasser
Copy link
Member

@glasser glasser commented Jan 26, 2015

Thanks, removed a now-obsolete comment and merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants