Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Proper use of path.join(..., ...) and path.sep to be more cross-platform. #303
This pull request features a lot of line changes to fix occurences where the
It appears Node.js
The reason I am putting this pull request early is to let you know it is there and such that inspection can happen early, as I feel this is a large code change it shouldn't be pulled in right away, but thorougly checked.
One example thing I need to do is to check for each file that I have modified whether there is a
I expect three more commits; one fixing the calls to a non-defined path and __dirname, one fixing broken URLs and possibly one to support Fibers and fix remaining bugs.
Hopefully this will help us to get towards a more cross-platform Meteor, reaching to not only the main OSes but perhaps even beyond. Thank you in advance... :)
Exactly, and Meteor doesn't work with 0.8.x for me due to Fibers.
So, we first need Fibers in order then correct it further and then do extensive testing before we can pull this in.
Yet, I already did the pull request to know it's there and easier tracking...
@n1mmy: Good news from my side; have upgraded to 0.8.2 and installed the latest Fibers and have continued testing. It appears that after one small fix the three examples work perfectly to me; so, the only work left to do is verify whether all the packages work fine...
It appears I left one other bug in this line (missing path.join) which I discovered while attempting to deploy, it appears I didn't try that earlier on that branch. Do you want me to redo the commit with your fixes (and a fix for this line) merged in so you can merge in a single commit?
Merged to devel! Thanks for all your work on this, and your patience on getting it merged =)
for the logs, I tested:
I think that covers all the changed code...