Do not crash when source plugins conflict. #3180
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| sourcePath: compileStep.inputPath | ||
| }; | ||
| allHandlersWithPkgs['js'] = { | ||
| pkg: { /* native handler */ }, |
There was a problem hiding this comment.
Let's just store packageName (or null) directly instead of pkg that we only use for its name
|
Thanks! Comments inline. |
1. Use allHandlersWithPkgs instead of duplicating data in allHandlers 2. Save only the pkg names instead of the whole packages
|
@glasser Have incorporated the feedback into the PR. I can rebase off current |
glasser
pushed a commit
that referenced
this pull request
Dec 11, 2014
|
Thanks, merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3179.
This is one approach to solve the problem by keeping the
pkginformation around until we have finished loading all the source handlers. This information is discarded afterwards.