New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set testing to automatically be run once. #3793

Closed
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
6 participants
@queso
Contributor

queso commented Feb 22, 2015

Right now you have to issue --test --once to get it to work the way a CI environment needs. That isn't expected and seems confusing to users. The velocity team decided this is the best way to handle that.

@Sanjo

This comment has been minimized.

Contributor

Sanjo commented Feb 22, 2015

👍

@stubailo

This comment has been minimized.

Contributor

stubailo commented Feb 24, 2015

so for developers the main way to use Velocity will be through the in-browser reporter?

@queso

This comment has been minimized.

Contributor

queso commented Feb 24, 2015

Sure, but when in a development mode the in-browser reporter runs just fine independent of this.

The --test flag was always intended as a way to run tests from the command line. It is a common confusion that you have to issue --test and --once to get a command line to exit properly.

@stubailo

This comment has been minimized.

Contributor

stubailo commented Feb 24, 2015

Does reactive test re-running not work from the command line? I'm curious if there are people who use Velocity primarily from the CLI.

@queso

This comment has been minimized.

Contributor

queso commented Feb 24, 2015

This isn't about test rerunning, this is about having a continuous integration solution for teams that want to full commit to long term testing solutions.

There are people working on a command line reporter, I believe this is something @Sanjo has started on?

@stubailo

This comment has been minimized.

Contributor

stubailo commented Feb 24, 2015

OK, sounds good to me. @n1mmy @ekatek what do you think?

@n1mmy

This comment has been minimized.

Member

n1mmy commented Feb 25, 2015

No real opinion here. Works for me if it works for others.

@awatson1978

This comment has been minimized.

Contributor

awatson1978 commented Feb 25, 2015

+1
Yup. When running from command line, running once is the preferred workflow.

@stubailo

This comment has been minimized.

Contributor

stubailo commented Feb 25, 2015

Merged: cc93674

Thanks!

@stubailo stubailo closed this Feb 25, 2015

@queso queso referenced this pull request Mar 6, 2015

Closed

Release 1.0.4 #3814

21 of 23 tasks complete

glasser added a commit that referenced this pull request Mar 6, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment