New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Velocity timing and mirror url fix #3957

Closed
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
2 participants
@Sanjo
Contributor

Sanjo commented Mar 18, 2015

Velocity has visited the mirror sometimes before
it is ready. With this new check that is already
used in the testing frameworks this no longer
happens.

This commit also handles the upcoming breaking
change regarding the rootUrl of the mirror.
See: https://github.com/meteor-velocity/velocity/issues/260

I've tested these changes manually. For reproducing the timing issue reliably I have added a blocking sleep of 10 seconds into the test app that I have used.

Velocity timing and mirror url fix
Velocity has visited the mirror sometimes before
it is ready. With this new check that is already
used in the testing frameworks this no longer
happens.

This commit also handles the upcoming breaking
change regarding the rootUrl of the mirror.
See: https://github.com/meteor-velocity/velocity/issues/260
@glasser

This comment has been minimized.

Member

glasser commented Mar 24, 2015

Thanks, merged. Does using a meteor with this patch require you to upgrade to a specific version of Velocity?

@glasser glasser closed this Mar 24, 2015

@Sanjo

This comment has been minimized.

Contributor

Sanjo commented Mar 24, 2015

Does using a meteor with this patch require you to upgrade to a specific version of Velocity?

No.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment