Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Enter nested job scope per package architecture when downloading #4163
This fixes a crash when two architectures need to be downloaded
Crash happened because progress object got reused for another download request,
How to reproduce:
CLA has been signed by the company (Hansoft) and sent via e-mail
This fixes a crash when two architectures need to be downloaded for the same package. It happens when building for non-host architecture if packages have not been cached yet. Crash happened because progress object got reused for another download request, and progress objects are not supposed to be reused.
Apparently it does not happen with a newly created/empty app. However, adding accounts-password will make the bug happen.
Detailed reproduction steps (when running meteor from git checkout):
You will get this as output:
Note that "meteor add" will cache the package already for the current architecture, so removing the package cache is necessary to fully simulate required conditions.
This situation is unlikely to happen on a developer's machine, as running the app will cache packages for the current architecture. In our case this crash happened on a build bot which did not have anything cached yet.