Reusable Accounts constructors #4233
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| this._initLocalStorage(); | ||
| }; | ||
|
|
||
| var Ap = AccountsClient.prototype = |
There was a problem hiding this comment.
This inheritance dance will become much cleaner when we enable ES6 class syntax in core packages.
benjamn
force-pushed
the
reusable-accounts-constructors
branch
from
433df8f
to
a608173
Compare
|
There's an argument in favor of making |
Closed
added 7 commits
May 12, 2015 12:43
This involves moving Accounts.* methods defined in accounts_common.js onto AccountsCommon.prototype.*.
Note that this constructor inherits from the AccountsCommon constructor. Naturally both of these constructor functions should become classes once we have support for ES6 classes.
There's an argument in favor of making AccountsClient available on both client and server, since server code might need to act as a client to an accounts server, too. I don't need that functionality yet, but it's something to think about.
Also share urls.* methods between all AccountsServer instances.
benjamn
force-pushed
the
reusable-accounts-constructors
branch
from
aaa4309
to
a2d588d
Compare
|
Closed via ff5fb16. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests reduces the assumption of a singleton
Accountsnamespace in theaccounts-basecore package, making it much easier to manage multiple accounts connections without duplicating code.At a high level, this refactoring was all about replacing the ad-hoc
Accountsobject with instances of the newAccountsClientandAccountsServerclasses, which inherit fromAccountsCommonso that methods can be shared (yay isomorphism!).As an example of a luxury that had to be given up in order to support multiple accounts instances, initialization code that used to run at the top level (like the auto-login code) is now called from the constructor functions.
I think it's now much clearer which methods and properties are available on the client, on the server, or in both places, since each environment has a distinct
.prototypewhere available methods are defined.