check: return instead of throw internally #4584
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -145,33 +139,41 @@ var typeofChecks = [ | |||
| [undefined, "undefined"] | |||
| ]; | |||
|
|
|||
| var checkSubtree = function (value, pattern) { | |||
| // Return `false` if it matches. Otherwise, return an object with a `message` and a `path` field. | |||
| var testSubtree = function (value, pattern) { | |||
There was a problem hiding this comment.
This doesn't correspond to test the way checkSubtree corresponded to check.
|
@wh0: Before we can merge your pull request, you'll need to sign the Meteor Contributor Agreement: https://contribute.meteor.com/ |
|
❤️ |
| if (value === null) | ||
| throw new Match.Error("Expected object, got null"); | ||
| return { |
There was a problem hiding this comment.
Since these if statements have become multiple lines, let's wrap the body in brackets.
|
@wh0 still waiting on the for loop change! Excited to get this change in. |
|
Yea! |
|
Why closing? |
|
whoa, I accidentally deleted my branch |
|
Lol, I should merge this |
|
Yes you should. :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Profiling our teams app showed that a lot of time was spent creating errors for the
checkpackage, which I assume creates a stack trace each time. For everyMatch.OptionalorMatch.OneOf, it would have to create a stack trace for the one choice that failed.Anyway, this PR modifies
check's internal implementation to use morereturninstead ofthrow, so as not to construct so many error objects. It shouldn't change the external API ofcheckorMatch.Where.This sped up one of our app's benchmarks, which called
Collection::findmany times (findinternally usescheckto validate its second parameter).