Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Append always a public property to Meteor.settings.public #4704
If no settings are given via --settings or METEOR_SETTINGS the structure is only initialized as an empty object. This causes, that the
In that case you can't set client settings during Meteor.startup(). In case of the missing initialized
It would be great if this could be appended, then a developer can add even public settings e.g. during initialization of packages.
This is not the same, because later on in your app you would like to extend the
If you assign (as you did) an empty new object to
So I still please to extend the
referenced this pull request
Sep 9, 2015
Hi David ( @dgreensp )
I am sorry to ask, but I can't understand your question / annotation currently.
From my tests, if you do not initialize an empty
Looking forward to your comments.
I read #5118 and I got your question. This is some kind of decision you have to take.
If you do not applly this patch, then you can't send settings to the client later in your app without initializing a settings structure via command-line or ENV.
IMHO I would suggest to change the doc like:
@TomFreudenberg, I did not realize that mutating