Skip to content

/ meteor

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate login option userEmail in favor of loginHint, also use with… #5313

Closed
wants to merge 2 commits into from
Closed

Deprecate login option userEmail in favor of loginHint, also use with… #5313

wants to merge 2 commits into from

Conversation

@bradvogel
Copy link
Contributor

@bradvogel bradvogel commented Sep 29, 2015

… Google signin.

Fixes #2422
@bradvogel
Deprecate login option userEmail in favor of loginHint, also use with…
Loading status checks…
c53eefe 
… Google signin.
This was referenced Sep 29, 2015
Closed
Closed
@bradvogel
Copy link
Contributor Author

@bradvogel bradvogel commented Sep 30, 2015

Tests failed but the look flaky.
@bradvogel
Copy link
Contributor Author

@bradvogel bradvogel commented Oct 1, 2015

@glasser @stubailo quick look over?
@bradvogel
Copy link
Contributor Author

@bradvogel bradvogel commented Oct 4, 2015

@glasser @stubailo ping :)
@stubailo
Copy link
Contributor

@stubailo stubailo commented Oct 4, 2015

@bradvogel curious why you decided to change the option name - is it to be the same as a the Google API option name?
@bradvogel
Copy link
Contributor Author

@bradvogel bradvogel commented Oct 5, 2015

@stubailo it was a suggestion from @estark37 here: #2790 (comment)
packages/meteor-developer/meteor_developer_client.js Outdated
options.loginHint = options.userEmail;
}

if (options && options.userEmail) {

This comment has been minimized.

Sign in to view
@zimme

zimme Oct 5, 2015
Contributor

Shouldn't this be used only if loginHint isn't specified as on line 35?
packages/meteor-developer/meteor_developer_client.js Outdated
options.loginHint = options.userEmail;
}

if (options && options.userEmail) {
loginUrl += '&user_email=' + encodeURIComponent(options.userEmail);

This comment has been minimized.

Sign in to view
@zimme

zimme Oct 5, 2015
Contributor

or maybe you intended on using options.loginHint here?
@stubailo
Copy link
Contributor

@stubailo stubailo commented Oct 5, 2015

@zimme thanks for jumping in with some comments!
@bradvogel
Fix copy/paste error.
Loading status checks…
d336985
@bradvogel
Copy link
Contributor Author

@bradvogel bradvogel commented Oct 5, 2015

Thanks guys. I meant loginHint instead userEmail - careless mistake. Thanks for the catch.
@zimme
Copy link
Contributor

@zimme zimme commented Oct 5, 2015

No problem, usually try and help out here and there whenever I feel like I have a minute over when looking around =)
@stubailo
Copy link
Contributor

@stubailo stubailo commented Oct 5, 2015

Merged! 24718de

Thanks for the contribution, @bradvogel!
@stubailo stubailo closed this Oct 5, 2015
@zimme
Copy link
Contributor

@zimme zimme commented Oct 5, 2015

Also maybe document that loginHint can be some sort of sub string of the google account id when used with the google accounts system. Saw something about that in the docs @bradvogel linked to.
@stubailo
Copy link
Contributor

@stubailo stubailo commented Oct 5, 2015

Good point. @bradvogel could you add something about that in a new PR please?
@bradvogel bradvogel deleted the mixmaxhq:add-loginHint-oauth-param branch Oct 5, 2015
@bradvogel bradvogel mentioned this pull request Oct 5, 2015
Merged
@bradvogel
Copy link
Contributor Author

@bradvogel bradvogel commented Oct 5, 2015

#5370
stubailo pushed a commit that referenced this pull request Oct 5, 2015
@bradvogel
Added comment per PR feedback in #5313 (comment)
Loading status checks…
a67e688
mquandalle pushed a commit to mquandalle/meteor-accounts that referenced this pull request Mar 31, 2016
@bradvogel
Added comment per PR feedback in meteor/meteor#5313 (comment)
f07ee3d
mquandalle pushed a commit to mquandalle/meteor-accounts that referenced this pull request Mar 31, 2016
@bradvogel
Added comment per PR feedback in meteor/meteor#5313 (comment)
b940b0e
mquandalle pushed a commit to mquandalle/meteor-accounts that referenced this pull request Mar 31, 2016
@bradvogel
Added comment per PR feedback in meteor/meteor#5313 (comment)
832cb71
mquandalle pushed a commit to mquandalle/meteor-accounts that referenced this pull request Mar 31, 2016
@bradvogel
Added comment per PR feedback in meteor/meteor#5313 (comment)
e953f2c
mquandalle pushed a commit to mquandalle/meteor-accounts that referenced this pull request Mar 31, 2016
@bradvogel
Added comment per PR feedback in meteor/meteor#5313 (comment)
72df47a
mquandalle pushed a commit to mquandalle/meteor-accounts that referenced this pull request Mar 31, 2016
@bradvogel
Added comment per PR feedback in meteor/meteor#5313 (comment)
ec115a3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@bradvogel @stubailo @zimme