Deprecate login option userEmail in favor of loginHint, also use with… #5313
Conversation
Tests failed but the look flaky. |
@bradvogel curious why you decided to change the option name - is it to be the same as a the Google API option name? |
@stubailo it was a suggestion from @estark37 here: #2790 (comment) |
options.loginHint = options.userEmail; | ||
} | ||
|
||
if (options && options.userEmail) { |
zimme
Oct 5, 2015
Contributor
Shouldn't this be used only if loginHint
isn't specified as on line 35?
Shouldn't this be used only if loginHint
isn't specified as on line 35?
options.loginHint = options.userEmail; | ||
} | ||
|
||
if (options && options.userEmail) { | ||
loginUrl += '&user_email=' + encodeURIComponent(options.userEmail); |
zimme
Oct 5, 2015
Contributor
or maybe you intended on using options.loginHint
here?
or maybe you intended on using options.loginHint
here?
@zimme thanks for jumping in with some comments! |
Thanks guys. I meant |
No problem, usually try and help out here and there whenever I feel like I have a minute over when looking around =) |
Merged! 24718de Thanks for the contribution, @bradvogel! |
Also maybe document that |
Good point. @bradvogel could you add something about that in a new PR please? |
… Google signin.
Fixes #2422