Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Update OAuth1Binding to allow post and get to receive params #539
Ok. I would have loved to have a test for this but this file is completely untested so I won't ask that of you. But test coverage around this area should probably be improved.
I'll merge this in, but I need to first ask you to sign our CLA: http://contribute.meteor.com/
added a commit
this pull request
Dec 12, 2012
Worth pointing out that there is a breaking change here -- the return value to OAuth1Binding.call and get. I think this is probably fine, because this is a semi-internal API, and it's probable that you are the first person using this externally (judging by this Pull Request).
I'll make sure, though, that this change is appropriately documented in History.md
@timhaines That's quite alright. I haven't gotten the linkedin issue resolved yet. First, I wanted to get #572 finished. But, it seemed like there might be a problem with some params that are being passed around between meteor and linkedin, which causes the bug error that I had documented above. In other words, I don't think it's on linkedin's end. It's me, passing or attempting to parse out incorrect parameters, in the request or the response, respectively.