/ meteor Public
Falsey in Collection#deny and Collection#allow #5442
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
This minor change will help prevent potential security issues.
Currently, the following snippet gets silently ignored:
Instead, the above snippet should throw an error.
The code currently does check truthy values, but doesn't check falsey values. Instead, it should check all defined values. This pull request fixes the check for truthy values with defined values.
I decided to use
Object#hasOwnPropertyinstead of e.g.
options[name] !== undefinedbecause in some situation
undefinedmight also be passed to one of the keys.
This issue came to light after a team member wrote the following piece of code:
Luckily this was flagged during a code review. But to my surprise, Meteor didn't throw any errors. After investigating, I found the truthy check to be the issue.
I hope to get this request merged!