Handle authentication type in Facebook #5694
Conversation
|
Seems useful, thanks! |
|
@nuvipannu 👍 ✨ @timbotnik Take a look at #5693 as well. 😁 While coding together with @nuvipannu, we discovered these limitations and thought it's a good thing for universe to fix them. For some reason the tests are failing, but doesn't seem to be related to our changes. 💫 |
|
You will probably need to update the documentation to show the new option before this is accepted. |
|
@robertpitt Where should I update the docs for these OAuth APIs? 💭 |
|
@robertpitt The relevant docs I found are these––but they don't contain the specific facebook/twitter information. |
IonicaBizau
force-pushed
the
facebook-force-login
branch
2 times, most recently
from
c7b6113
to
67d9cb7
Compare
|
@benjamn What's pending for this to be merged? |
|
@benjamn @JonathanHindi I'm pretty sad to see how much time it takes for a simple fix like this to get merged (actually, this is not even merged yet). 😞 |
|
|
||
| // Handle authentication type (e.g. for force login you need authType: "reauthenticate") | ||
| if (options.authType) { | ||
| loginUrl = loginUrl + "&authType=" + options.authType; |
There was a problem hiding this comment.
I think this should maybe be
loginUrl += "&authType=" + encodeURIComponent(options.authType);to make sure the authType is properly URL-escaped?
There was a problem hiding this comment.
@benjamn I don't think that's really needed, but just in case, I just pushed it.
IonicaBizau
force-pushed
the
facebook-force-login
branch
from
a03869c
to
05803d6
Compare
|
@JonathanHindi @benjamn Any ideas why the tests are failing? 💥 Same happens in #6987. |
|
Hey @nuvipannu and @JonathanHindi . Sorry it's taken us so long to look at this.We're now working through our PR backlog and merging whatever we can, this looks like a good candidate. Could you please rebase against the latest |
Allow using authType in Facebook login Facebook API Docs: https://developers.facebook.com/docs/facebook-login/reauthentication
IonicaBizau
force-pushed
the
facebook-force-login
branch
from
05803d6
to
3c03fae
Compare
|
@zol Thanks for the feedback. I have just rebased and pushed. Waiting for the tests. ⏳ |
|
@zol @nuvipannu Tests are passing 🎉 🚀 |
|
Merged, thank you. |
|
@nuvipannu Finally! Yay! 🎉 😁 🎊 |
|
is this documented on the Guide http://docs.meteor.com/api/accounts.html#Meteor-loginWith ? thanks |
Allow using authType in Facebook login (https://developers.facebook.com/docs/facebook-login/reauthentication) 🎈