Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Factor out providers from accounts ui unstyled #572
@avital, after thinking about your comments in #566 some more, I realized that I was also missing a test. Upon writing the test, I had also noticed that we were not accounting for dupe providers pushed onto
Thanks for the feedback.
FYI, would help to add this to the official docs:
Oh, and any plans to put this on Travis? That would be
As for using travis, we will have to definitely invest in our testing infrastructure going forward, and @sixolet seems to be taking some initiative on that... But it'll take a while.
Also, I've recently learned about circleci, which claims to be like travis but better (and faster)... but we'd have to look into each to evaluate them...
Looking forward to more work on testing infrastructure. Happy to help too. Will make your release cycles tighter. Probably preaching to the choir.
I use circleci for my private projects! :) It's very awesome, but I don't think they are free for open source, whereas Travis is.