Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Make cursor.map/forEach follow the ECMAScript APIs #63
I think this is a good idea, with some changes.
1: The API should follow the full ECMA 5 spec for
2: The same API should be on the server, as implemented in
3: Tests for client and server APIs. (
@debergalis Sorry I was unclear...
But it seems to be quite fundamental in Coffeescript to protect you from accidentally creating global variables (see http://coffeescript.org/#lexical_scope). As far as I know, the "bare" option is mainly aimed at e.g. Node's module loader, that provides it own wrapper anyway.
How'd you rebase? I'd have expected
Why do you say
In map, we can use the new index.
But it's early and I haven't had my coffee yet.
For testing: see the test suite in
Yes, I merged by accident. I'm still learning my way around git. Sorry for the mess. I've fixed the cursor_pos thing. I'm not sure why I thought this was necessary.
I've made the two changes you suggested as well. As for the testing, I'll starting looking at it soon. In the meantime, if anyone has any suggestions for how I can pull those merges our of this pull request, I'd be very obliged.
@iwoj: It might help a lot if you were to do the changes again against the current devel branch (not against master), this way you can squash the few amount of changes you have into a single commit as well as making it easier for them to pull in. So, in short:
@debergalis: Why did you refer to those two issues, was that by accident? I don't see how they are relevant.