New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow --port in "test" to support a bindaddr, same as non-test #6964

Merged
merged 1 commit into from May 3, 2016

Conversation

Projects
None yet
2 participants
@abernix
Member

abernix commented May 3, 2016

The test mode wasn't passing the proper proxyHost and proxyPort values to runAll. This changes the behaviour to work the same as the regular run mode and also adds tests for both modes to test the bindaddr (localAddress) is taking effect properly.

Fixes #6961

Allow --port in "test" to allow a bindaddr, same as non-test
The `test` mode wasn't passing the proper proxyHost and proxyPort values to runAll.  This changes the behaviour to work the same as the regular `run` mode and also adds tests for both modes to test the bindaddr (localAddress) is taking effect properly.

Fixes #6961

@abernix abernix force-pushed the abernix:issue-6961-fix-test-bindaddr branch from ae3b366 to 454a761 May 3, 2016

@tmeasday tmeasday self-assigned this May 3, 2016

@tmeasday tmeasday merged commit b2bb995 into meteor:devel May 3, 2016

1 of 2 checks passed

ci/circleci Your tests failed on CircleCI
Details
CLA Author has signed the Meteor CLA.
Details
@tmeasday

This comment has been minimized.

Contributor

tmeasday commented May 3, 2016

This is great, thanks @abernix

tmeasday added a commit that referenced this pull request May 3, 2016

@abernix abernix deleted the abernix:issue-6961-fix-test-bindaddr branch May 4, 2016

abernix added a commit to abernix/meteor that referenced this pull request May 23, 2016

tmeasday added a commit that referenced this pull request May 23, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment