Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upConversation
abernix
force-pushed the
abernix:issue-6961-fix-test-bindaddr
branch
from
ae3b366
to
454a761
May 3, 2016
abernix
referenced this pull request
May 3, 2016
Closed
Allow the test command to run on a specific interface with --port IP:PORT #6961
tmeasday
self-assigned this
May 3, 2016
tmeasday
merged commit b2bb995
into
meteor:devel
May 3, 2016
This comment has been minimized.
This comment has been minimized.
|
This is great, thanks @abernix |
added a commit
that referenced
this pull request
May 3, 2016
abernix
deleted the
abernix:issue-6961-fix-test-bindaddr
branch
May 4, 2016
added a commit
to abernix/meteor
that referenced
this pull request
May 23, 2016
added a commit
that referenced
this pull request
May 23, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
abernix commentedMay 3, 2016
•
edited
The
testmode wasn't passing the proper proxyHost and proxyPort values to runAll. This changes the behaviour to work the same as the regularrunmode and also adds tests for both modes to test the bindaddr (localAddress) is taking effect properly.Fixes #6961