Allow --port in "test" to support a bindaddr, same as non-test #6964
Conversation
The `test` mode wasn't passing the proper proxyHost and proxyPort values to runAll. This changes the behaviour to work the same as the regular `run` mode and also adds tests for both modes to test the bindaddr (localAddress) is taking effect properly. Fixes #6961
|
This is great, thanks @abernix |
tmeasday
added a commit
that referenced
this pull request
May 3, 2016
abernix
added a commit
to abernix/meteor
that referenced
this pull request
May 23, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
The
testmode wasn't passing the proper proxyHost and proxyPort values to runAll. This changes the behaviour to work the same as the regularrunmode and also adds tests for both modes to test the bindaddr (localAddress) is taking effect properly.Fixes #6961