-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Remove the google profile
scope.
#6975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'm a bit worried this might be a breaking change for people who are currently using the profile information in their apps. Perhaps there is something else we could do to allow one to disable the |
@stubailo, We could make it configurable via Meteor.settings, and have it add the Having said that, there are a couple more things I would like to make configurable about the Google auth process. Would you advise to add them to this PR or create a separate one once this one is agreed upon and merged? |
@MasterAM, sorry about the delays here. A couple of things:
|
@MasterAM, thanks again for this PR. We're still waiting to hear about the comments above--just to let you know, we'll be closing this PR in a week if we don't. |
Hi Tom, Forgot about the PR, thanks for reminding me.
|
Thanks again! Also, can you merge |
The `email` scope is enough for getting the required data, including the user ID.
The default value for the `requestPermissions` option is now `profile`, thus preserving the old behavior in case the option was not explicitly set. Added a note in the History.md file regarding this change.
9939e16
to
ca09e9d
Compare
Rebased, made changes and added the changelog entry. I Hope it's not too verbose. Note to users:
If unsure, take a look at the code, it's really simple. |
Thanks very much for your hard work on this @MasterAM |
This is a re-submission of #5699.
The
email
scope is enough for getting the required data, including the user ID, so no need for theprofile
scope, which may deter users.The discussion started at #5650
Our team anticipates Google to be a major choice for users during signup, so we would like to alleviate some of the concerns that requesting the
profile
scope may bring.We would also like developers to have more control over more aspects, such as the way the popup window behaves (e.g, forcing it upon login for situations where there is more than one logged-in Google account).
I would really like to hear your opinions in the discussion thread.