Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax release constraints for #7004 #7084

Closed
wants to merge 8 commits into from
Closed

Conversation

@tmeasday
Copy link
Contributor

@tmeasday tmeasday commented May 19, 2016

Ready for review @benjamn

tmeasday added 2 commits May 11, 2016
Mainly because the dev bundle is so big, it took upwards on 5 mins (on my MBP w/ SSD) to copy the warehouse packages into the sandbox. AFAICT there is no reason not to symlink it if we can.
For #7004. Still working on the self test but it appears to work :)
@benjamn

This comment has been minimized.

Copy link
Member

@benjamn benjamn commented on tools/tool-testing/selftest.js in 6ae4434 May 19, 2016

I think you just need to call builder.complete() now. Example here.

This comment has been minimized.

Copy link
Contributor Author

@tmeasday tmeasday replied May 19, 2016

👍

@tmeasday tmeasday changed the title [WIP] Relax release constraints for #7004 Relax release constraints for #7004 May 19, 2016
@benjamn
Copy link
Member

@benjamn benjamn commented May 19, 2016

I've read over the code and everything makes sense to me. I'd like to play with it a bit more just to make sure the workflow for updating packages is smooth, but I don't have an objection to merging this to devel if the tests pass.

@tmeasday
Copy link
Contributor Author

@tmeasday tmeasday commented May 19, 2016

Oh, I think maybe we should merge it to release-1.4 actually? not sure.

We should probably do a proper beta release with it in it so we can test the code for real before merging to devel

@tmeasday
Copy link
Contributor Author

@tmeasday tmeasday commented May 19, 2016

Oh and I expect the tests to pass, I'm rerunning them

@abernix
Copy link
Member

@abernix abernix commented May 20, 2016

I re-ran this on CI 2.5x last night unsuccessfully. Mostly CI silliness (consider merging #7063 with Ben's 05dfe24 cherry-picked on top), but autoupdate fails on my local box too so that's probably an actual issue.

@tmeasday
Copy link
Contributor Author

@tmeasday tmeasday commented May 20, 2016

Yes, I've concluded this is a real failure too. In fact I'm no longer sure
auto update is a flaky test
On Fri, 20 May 2016 at 9:35 AM, Jesse Rosenberger notifications@github.com
wrote:

I re-ran this on CI 2.5x last night unsuccessfully. Mostly CI silliness
(consider merging #7063 #7063 with
Ben's 05dfe24
05dfe24
cherry-picked on top), but autoupdate fails on my local box too so that's
probably an actual issue.


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#7084 (comment)

The issue was the order of the two matches kept changing due to ..?.. (various factors I guess).
@tmeasday
Copy link
Contributor Author

@tmeasday tmeasday commented May 20, 2016

@benjamn If you are happy with this, let's merge it to release-1.4. Tests are now passing.

@tmeasday
Copy link
Contributor Author

@tmeasday tmeasday commented May 20, 2016

Merged to release-1.4!!

@tmeasday tmeasday closed this May 20, 2016
benjamn added a commit that referenced this pull request Jun 29, 2016
@benjamn
Copy link
Member

@benjamn benjamn commented Jun 29, 2016

@tmeasday It looks like some of these commits made it into release-1.4 but not all of them. Whatever happened happened before I closed #7035. If you have any idea what happened, I'm curious, but it seems to be sorted out now.

benjamn added a commit that referenced this pull request Feb 7, 2017
Package version unpinning (#7084) removed all exact package@=version
constraints derived from the current release.

As we discovered with Meteor 1.4.2.4 (#8306), this meant releases no
longer had any power to enforce package upgrades, which is why the
follow-up Meteor 1.4.2.5 release (#8311) was necessary.

This commit has the same effect as putting package@version in your
.meteor/packages file for every local/core package that your app uses.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants