Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes Velocity testing code #7235

Merged
merged 1 commit into from Jun 16, 2016
Merged

Conversation

@ghost
Copy link

@ghost ghost commented Jun 16, 2016

The support of the Velocity testing functionality has been dropped with Meteor 1.3 by me, who maintained the Velocity Meteor fork that had some additional functionality in it that was required to run tests with Velocity. Therefore the code that is removed in this PR no longer serves any purpose.

@benjamn
Copy link
Member

@benjamn benjamn commented Jun 16, 2016

Thanks for cleaning up this code, and for working on it in the first place. I applaud you for making significant contributions to the Meteor platform when it wasn't always easy or rewarding. It's my full-time job, so I know how much of an uphill battle it can be. I like to think contributing is getting easier, but we've definitely still got a long road ahead.

Cheers

@benjamn benjamn merged commit 88111e2 into meteor:devel Jun 16, 2016
3 checks passed
3 checks passed
CLA Author has signed the Meteor CLA.
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants