Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upConversation
jdivy
reviewed
Jun 17, 2016
| @@ -1413,6 +1413,10 @@ testCommandOptions = { | ||
| deploy: { type: String }, | ||
| production: { type: Boolean }, | ||
| settings: { type: String }, | ||
| // Indicates whether these self-tests are running headless, e.g. in a | ||
| // continuous integration testing environment, where visual niceties | ||
| // like progress bars and spinners are unimportant. |
This comment has been minimized.
This comment has been minimized.
jdivy
Jun 17, 2016
Contributor
I debated on whether or not to even keep this documentation, and of course I left a minor copy/paste error. Let me know if you would rather just strip this comment altogether.
This comment has been minimized.
This comment has been minimized.
|
Looks good to me! |
jdivy
deleted the
jdivy:provide-headless-option-in-regular-tests
branch
Jun 17, 2016
hwillson
referenced this pull request
Mar 8, 2017
Closed
Need some progress output when stdout is not a TTY #3316
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
jdivy commentedJun 17, 2016
In a nutshell, I think the
--headlessoption should be available to both thetestandtest-packagescommand. I couldn't think of a good reason why it's not available, and it would be much nicer to see CI logs that don't have many lines of rotating progress bars.