Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow `--headless` option for `test` and `test-packages` #7245

Merged

Conversation

@jdivy
Copy link
Contributor

@jdivy jdivy commented Jun 17, 2016

In a nutshell, I think the --headless option should be available to both the test and test-packages command. I couldn't think of a good reason why it's not available, and it would be much nicer to see CI logs that don't have many lines of rotating progress bars.

screen shot 2016-06-17 at 1 11 21 pm

@@ -1413,6 +1413,10 @@ testCommandOptions = {
deploy: { type: String },
production: { type: Boolean },
settings: { type: String },
// Indicates whether these self-tests are running headless, e.g. in a
// continuous integration testing environment, where visual niceties
// like progress bars and spinners are unimportant.

This comment has been minimized.

@jdivy

jdivy Jun 17, 2016
Author Contributor

I debated on whether or not to even keep this documentation, and of course I left a minor copy/paste error. Let me know if you would rather just strip this comment altogether.

@benjamn benjamn merged commit fbfa1b5 into meteor:devel Jun 17, 2016
3 checks passed
3 checks passed
CLA Author has signed the Meteor CLA.
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@benjamn
Copy link
Member

@benjamn benjamn commented Jun 17, 2016

Looks good to me!

@jdivy jdivy deleted the jdivy:provide-headless-option-in-regular-tests branch Jun 17, 2016
@benjamn benjamn mentioned this pull request Jun 22, 2016
6 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants