Allow --headless option for test and test-packages
#7245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1413,6 +1413,10 @@ testCommandOptions = { | |||
| deploy: { type: String }, | |||
| production: { type: Boolean }, | |||
| settings: { type: String }, | |||
| // Indicates whether these self-tests are running headless, e.g. in a | |||
| // continuous integration testing environment, where visual niceties | |||
| // like progress bars and spinners are unimportant. | |||
There was a problem hiding this comment.
I debated on whether or not to even keep this documentation, and of course I left a minor copy/paste error. Let me know if you would rather just strip this comment altogether.
|
Looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a nutshell, I think the
--headlessoption should be available to both thetestandtest-packagescommand. I couldn't think of a good reason why it's not available, and it would be much nicer to see CI logs that don't have many lines of rotating progress bars.