Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upConversation
tmeasday
referenced this pull request
Jun 23, 2016
Closed
Allow passing options in the MongoDB driver #6958
tmeasday
reviewed
Jun 23, 2016
| // set it for replSet, it will be ignored if we're not using a replSet. | ||
| mongoOptions.server.poolSize = options.poolSize; | ||
| mongoOptions.replSet.poolSize = options.poolSize; | ||
| mongoOptions.poolSize = options.poolSize; |
This comment has been minimized.
This comment has been minimized.
tmeasday
Jun 23, 2016
Contributor
Has this poolSize option changed? If so we should probably fix this
This comment has been minimized.
This comment has been minimized.
dburles
Jun 23, 2016
Contributor
Only in how you pass it in, the new mongo driver takes care of where it needs to go
This comment has been minimized.
This comment has been minimized.
tmeasday
Jun 23, 2016
Contributor
Does the old code work though? It seems surprising that this passed our testing of the new driver..
This comment has been minimized.
This comment has been minimized.
dburles
Jun 23, 2016
Contributor
Oh right yeah, well as far as I've looked into things it seems like legacy options will work just fine, though I'm not totally sure what happens with safe, I think it may just be ignored as it's the default on later Mongo, but I could be wrong.
This comment has been minimized.
This comment has been minimized.
tmeasday
Jun 23, 2016
Contributor
Maybe remove this from the PR then, I think it muddies the waters a little
This comment has been minimized.
This comment has been minimized.
tmeasday
reviewed
Jun 23, 2016
| check(options, Object); | ||
| Mongo._connectionOptions = options; | ||
| } | ||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Looking good @dburles |
This comment has been minimized.
This comment has been minimized.
|
For reference here's the relevant docs for the newer options http://mongodb.github.io/node-mongodb-native/2.1/reference/connecting/connection-settings/ |
dburles
changed the title from
first pass at custom mongo connection options api for #6958
to
User defined mongo connection options API for #6958
Jun 23, 2016
This comment has been minimized.
This comment has been minimized.
|
Seems pretty good now https://github.com/meteor/meteor/pull/7277/files |
tmeasday
reviewed
Jun 23, 2016
| /** | ||
| * @summary Allows for user specified connection options | ||
| * @locus Server | ||
| * @param {Object} options User specified Mongo connection options |
This comment has been minimized.
This comment has been minimized.
tmeasday
Jun 23, 2016
Contributor
Can we add a link to the mongo docs so people know what these options are?
This comment has been minimized.
This comment has been minimized.
dburles
force-pushed the
dburles:mongo-connection-options
branch
from
baec319
to
edb56af
Jun 23, 2016
This comment has been minimized.
This comment has been minimized.
|
Just a heads up, this was definitely merged, but for some reason now it's not included in the |
This comment has been minimized.
This comment has been minimized.
|
Any idea what happened here @benjamn? |
added a commit
that referenced
this pull request
Jun 26, 2016
This comment has been minimized.
This comment has been minimized.
|
Not sure why it disappeared, but I've cherry-picked it back onto release-1.4: 2654fe6 |
dburles commentedJun 23, 2016
•
edited
For #6958
I noticed the API has changed for a bunch of the existing options used in
mongo_driver.jssuch as{ safe: true }now replaced by: https://docs.mongodb.com/manual/core/replica-set-write-concern/ but that is a bit out of scope for this PR. Maybe something to be looked at though.