New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom config.xml tags with App.appendToConfig #7307

Closed
wants to merge 3 commits into
base: devel
from

Conversation

Projects
None yet
3 participants
@grsabreu
Contributor

grsabreu commented Jun 27, 2016

Re-open #5846, as requested by @zol :

As I also needed a solution for #5756, I attempted to implement it.
So now you're able to append custom tags to config.xml. Eg:

App.appendToConfig(`
  <universal-links>
    <host name="myhost.com"/>
  </universal-links>
`);

and config.xml will get:

<?xml version="1.0"?>
<widget id="com.example.ul" version="1.5.5" xmlns="http://www.w3.org/ns/widgets" xmlns:cdv="http://cordova.apache.org/ns/1.0">
  <name>UniversalLinks</name>
  <description>Another app</description>
  <author href="twitter.com/_gabrielrubens" email="grsabreu@gmail.com">Gabriel Rubens</author>

  <universal-links>
    <host name="myhost.com"/>
  </universal-links>
</widget>

Let me know how I can improve something!
Cheers

@grsabreu grsabreu changed the title from Feature custom config xml tags to Feature custom config xml tags with App.appendToConfig Jun 27, 2016

@grsabreu grsabreu changed the title from Feature custom config xml tags with App.appendToConfig to Feature custom config.xml tags with App.appendToConfig Jun 27, 2016

@grsabreu grsabreu changed the title from Feature custom config.xml tags with App.appendToConfig to Custom config.xml tags with App.appendToConfig Jun 27, 2016

@zol zol self-assigned this Jun 28, 2016

zol pushed a commit that referenced this pull request Jun 28, 2016

Zoltan Olah
@zol

This comment has been minimized.

Contributor

zol commented Jun 28, 2016

Merged, thanks @grsabreu !

@zol zol closed this Jun 28, 2016

@grsabreu

This comment has been minimized.

Contributor

grsabreu commented Jun 29, 2016

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment