Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Angular2 to the example repositories #7363

Merged
merged 2 commits into from Jul 20, 2016
Merged

Added Angular2 to the example repositories #7363

merged 2 commits into from Jul 20, 2016

Conversation

@dotansimha
Copy link
Contributor

@dotansimha dotansimha commented Jul 7, 2016

I added a new base application example, it includes Meteor 1.3 application with Angular2 and Angular2-Meteor applications, along with basic "Hello World" example with unit tests and all the required dependencies for Angular2-Meteor applications.

The idea is to get an easy start for new Angular2-Meteor developers, by providing the command:
meteor create angular2.

Thanks.

@lorensr
Copy link
Member

@lorensr lorensr commented Jul 12, 2016

I can't judge the angular, but I'm in favor of the cmd addition!

Related: #6974 (comment)

@benjamn
Copy link
Member

@benjamn benjamn commented Jul 19, 2016

I think the command would be meteor create --example angular2, right? I haven't thought about this in a while, so I might be wrong…

@zol
Copy link
Contributor

@zol zol commented Jul 19, 2016

Great, thank you. Please rename the example to angular2-boilerplate and we'll merge this PR.

@lorensr
Copy link
Member

@lorensr lorensr commented Jul 19, 2016

Yep, it'll be --example:

image

@dotansimha
Copy link
Contributor Author

@dotansimha dotansimha commented Jul 20, 2016

Yeah sure it will be with --example flag.
@zol - I updated the name.
Thanks!

@zol
Copy link
Contributor

@zol zol commented Jul 20, 2016

Great, thanks!

@zol zol merged commit b32c5cd into meteor:devel Jul 20, 2016
3 checks passed
3 checks passed
CLA Author has signed the Meteor CLA.
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abernix abernix mentioned this pull request Jul 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants