New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.3.4.3 #7369

Merged
merged 15 commits into from Jul 9, 2016

Conversation

Projects
None yet
5 participants
@benjamn
Member

benjamn commented Jul 8, 2016

Unfortunately, the following claim in the release notes for the 1.3.4.2 release was not entirely true:

  • The meteor node and meteor npm commands now respect .meteor/release when resolving which versions of node and npm to invoke. Note that you must meteor update to 1.3.4.2 before this logic will take effect, but it will work in all app directories after updating, even those pinned to older versions. #7338

Specifically, running meteor update to update to 1.3.4.2 was not actually enough to modify the ~/.meteor/meteor symlink (or AppData\Local\.meteor\meteor.bat on Windows), which prevented the new behavior of meteor node and meteor npm from taking effect.

Thanks to @rhettlivingston for providing quick feedback on these concerns!

@benjamn benjamn added this to the Release 1.3.4.3 milestone Jul 8, 2016

@benjamn benjamn self-assigned this Jul 8, 2016

@kachkaev

This comment has been minimized.

kachkaev commented Jul 8, 2016

@benjamn is there a chance of releasing another 1.4-beta with this problem solved? Looks like I've got some problems because meteor node --version is still v0.10.45 in beta.7.

If a release not require any complex merging, of course.

@benjamn

This comment has been minimized.

Member

benjamn commented Jul 8, 2016

@kachkaev of course! I haven't even rebased https://github.com/meteor/meteor/tree/release-1.4 against these changes yet :)

@benjamn benjamn force-pushed the release-1.3.4.3 branch from 158c288 to 2d67898 Jul 8, 2016

benjamn added some commits Jul 8, 2016

Peg accounts-password npm-bcrypt version to 0.8.6_2 exactly.
With the simultaneous development of Meteor 1.4, npm-bcrypt@0.8.7 has
already been published, but we very much do not want to use that version
with Meteor 1.3.4.3, since it doesn't work with Node 0.10.46.

@benjamn benjamn merged commit 4863915 into devel Jul 9, 2016

4 checks passed

CLA Author has signed the Meteor CLA.
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@benjamn

This comment has been minimized.

Member

benjamn commented on 90a15fa Jul 10, 2016

This commit message was accidentally git commit -c'd from the 1.3.4.2 release commit. The release version should have read 1.3.4.3.

@mjgallag

This comment has been minimized.

mjgallag commented on packages/accounts-password/package.js in ac81da3 Jul 11, 2016

@benjamn when I upgraded meteor to 1.3.4.1 npm-bcrypt got upgraded to 0.8.7 and then when I upgraded meteor to 1.3.3.4 npm-bcrypt got downgraded to 0.8.6_2. Is there any chance at all that accounts-passwords created with npm-bcrypt@0.8.7 would not work with npm-bcrypt@0.8.6_2?

This comment has been minimized.

Member

benjamn replied Jul 11, 2016

Yes, the downgrade was deliberate, since bcrypt@0.8.7 was published using Meteor 1.4 / Node 4, and uses a different version of nan than bcrypt@0.8.6. In theory Meteor should be able to rebuild the bcrypt package automatically, but that requires you to have an appropriate compiler toolchain.

This comment has been minimized.

mjgallag replied Jul 11, 2016

@benjamn sorry I wasn't clear. I meant the passwords themselves, not accounts-password package.

This comment has been minimized.

mjgallag replied Jul 11, 2016

@benjamn just ignore this completely, apologies. I just tested this setting a password with npm-bcrypt@0.8.7 and I was able to login with npm-bcrypt@0.8.6_2. I must have fat-fingered my password when I set it.

@Spaxe

This comment has been minimized.

Spaxe commented on 9e6ebde Jul 18, 2016

+1. I was wondering if dev_bundle should really be ignored. Thanks for this.

@mquandalle

This comment has been minimized.

Contributor

mquandalle commented on tools/static-assets/skel/.meteor/.gitignore in 9e6ebde Jul 19, 2016

@benjamn Shouldn’t this be removed now?

This comment has been minimized.

Member

benjamn replied Jul 19, 2016

My plan is to revert this whole commit in Meteor 1.4, though I don't see any harm in continuing to ignore .meteor/dev_bundle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment