Release 1.3.4.3

[benjamn]

Unfortunately, the following claim in the release notes for the 1.3.4.2 release was not entirely true:

• The meteor node and meteor npm commands now respect .meteor/release when resolving which versions of node and npm to invoke. Note that you must meteor update to 1.3.4.2 before this logic will take effect, but it will work in all app directories after updating, even those pinned to older versions. #7338

Specifically, running meteor update to update to 1.3.4.2 was not actually enough to modify the ~/.meteor/meteor symlink (or AppData\Local\.meteor\meteor.bat on Windows), which prevented the new behavior of meteor node and meteor npm from taking effect.

Thanks to @rhettlivingston for providing quick feedback on these concerns!

[kachkaev]

@benjamn is there a chance of releasing another 1.4-beta with this problem solved? Looks like I've got some problems because meteor node --version is still v0.10.45 in beta.7.

If a release not require any complex merging, of course.

[benjamn]

@kachkaev of course! I haven't even rebased https://github.com/meteor/meteor/tree/release-1.4 against these changes yet :)

[benjamn]

This commit message was accidentally git commit -c'd from the 1.3.4.2 release commit. The release version should have read 1.3.4.3.

[mjgallag]

@benjamn when I upgraded meteor to 1.3.4.1 npm-bcrypt got upgraded to 0.8.7 and then when I upgraded meteor to 1.3.3.4 npm-bcrypt got downgraded to 0.8.6_2. Is there any chance at all that accounts-passwords created with npm-bcrypt@0.8.7 would not work with npm-bcrypt@0.8.6_2?

[benjamn]

Yes, the downgrade was deliberate, since bcrypt@0.8.7 was published using Meteor 1.4 / Node 4, and uses a different version of nan than bcrypt@0.8.6. In theory Meteor should be able to rebuild the bcrypt package automatically, but that requires you to have an appropriate compiler toolchain.

[mjgallag]

@benjamn sorry I wasn't clear. I meant the passwords themselves, not accounts-password package.

[mjgallag]

@benjamn just ignore this completely, apologies. I just tested this setting a password with npm-bcrypt@0.8.7 and I was able to login with npm-bcrypt@0.8.6_2. I must have fat-fingered my password when I set it.

[Spaxe]

+1. I was wondering if dev_bundle should really be ignored. Thanks for this.

[mquandalle]

@benjamn Shouldn’t this be removed now?

[benjamn]

My plan is to revert this whole commit in Meteor 1.4, though I don't see any harm in continuing to ignore .meteor/dev_bundle.