Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.3.4.3 #7369

Merged
merged 15 commits into from Jul 9, 2016
Merged

Release 1.3.4.3 #7369

merged 15 commits into from Jul 9, 2016

Conversation

benjamn
Copy link
Contributor

@benjamn benjamn commented Jul 8, 2016

Unfortunately, the following claim in the release notes for the 1.3.4.2 release was not entirely true:

  • The meteor node and meteor npm commands now respect .meteor/release when resolving which versions of node and npm to invoke. Note that you must meteor update to 1.3.4.2 before this logic will take effect, but it will work in all app directories after updating, even those pinned to older versions. #7338

Specifically, running meteor update to update to 1.3.4.2 was not actually enough to modify the ~/.meteor/meteor symlink (or AppData\Local\.meteor\meteor.bat on Windows), which prevented the new behavior of meteor node and meteor npm from taking effect.

Thanks to @rhettlivingston for providing quick feedback on these concerns!

@benjamn benjamn added this to the Release 1.3.4.3 milestone Jul 8, 2016
@benjamn benjamn self-assigned this Jul 8, 2016
@kachkaev
Copy link

kachkaev commented Jul 8, 2016

@benjamn is there a chance of releasing another 1.4-beta with this problem solved? Looks like I've got some problems because meteor node --version is still v0.10.45 in beta.7.

If a release not require any complex merging, of course.

@benjamn
Copy link
Contributor Author

benjamn commented Jul 8, 2016

@kachkaev of course! I haven't even rebased https://github.com/meteor/meteor/tree/release-1.4 against these changes yet :)

@benjamn benjamn merged commit 4863915 into devel Jul 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants